Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix std::string_view being identified as a container #229

Merged
merged 1 commit into from
Nov 5, 2022
Merged

Fix std::string_view being identified as a container #229

merged 1 commit into from
Nov 5, 2022

Conversation

marzer
Copy link
Contributor

@marzer marzer commented Nov 4, 2022 •
edited
Loading

This fixes get<T>() (and by extension operator==) for situations where a value is stored as a std::string_view.

github-actions[bot]
github-actions bot reviewed Nov 4, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

include/argparse/argparse.hpp Show resolved Hide resolved
@skrobinson skrobinson mentioned this pull request Nov 4, 2022
Merged
@marzer
Copy link
Contributor Author

marzer commented Nov 5, 2022

@p-ranav Anything further for me to do on this?

@p-ranav
Copy link
Owner

p-ranav commented Nov 5, 2022

Looks good to me.

@p-ranav p-ranav merged commit 6960571 into p-ranav:master Nov 5, 2022
@Porkepix Porkepix mentioned this pull request Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skrobinson skrobinson skrobinson left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marzer @p-ranav @skrobinson